Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix literal of Nullable and order of limit & offset in Clickhouse. #2983

Closed
wants to merge 3 commits into from

Conversation

Lunaticus7
Copy link
Contributor

@Lunaticus7 Lunaticus7 commented Sep 17, 2021

Fix two bugs of Clickhouse backend.

  1. The order of limit and offset in compiled SQL is reversed 🤣.
    https://clickhouse.tech/docs/en/sql-reference/statements/select/limit/#limit-clause

  2. When literal None to some Nullable column's type will raise error.

expr = table.mutate(ibis.literal(None, table['nullable_string_column'].type()).name('new_column'))
expr.compile()
# AttributeError: 'NoneType' object has no attribute 'replace'

@github-actions
Copy link
Contributor

Unit Test Results

       19 files         19 suites   1h 34m 25s ⏱️
10 756 tests   8 401 ✔️   2 354 💤 1 ❌
54 461 runs  41 185 ✔️ 13 274 💤 2 ❌

For more details on these failures, see this check.

Results for commit e5c79a5.

@Lunaticus7
Copy link
Contributor Author

CI failed, emmmm, there is an import error ?

https://github.com/ibis-project/ibis/pull/2983/checks?check_run_id=3632398102#step:11:105

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2021

@Lunaticus7 Unfortunately, we're now picking up a later version of impyla that uses a dependency that isn't declared in its setup.py. I'll patch the conda-forge package to include this dependency, hopefully I don't also need to package puresasl as well.

I've created an issue on the impyla issue tracker (cloudera/impyla#471).

@cpcloud
Copy link
Member

cpcloud commented Sep 18, 2021

I've put up a PR to add pure-sasl to the impyla conda package, which should at least allow CI to pass conda-forge/impyla-feedstock#28

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits.

Other than the CI (which doesn't really matter for this PR anyway, but we should still wait for it to pass) this LGTM.

ibis/backends/clickhouse/registry.py Show resolved Hide resolved
@Lunaticus7
Copy link
Contributor Author

Closed, split this PR to #2984 #2985

cc @cpcloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants