Added ability to be used using a switch statment (#46) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osmium-dev thank you, this is a really cool idea! Can you add a few tests to ensure this stays working going forward? Thanks! |
|
I would love these, @samyosm can you please, also add the tests so that @ianstormtaylor can merge :) |
634750802
reviewed
Nov 12, 2022
| if (hotkey.ctrlKey || hotkey.metaKey) name.push("mod"); | ||
| if (hotkey.shiftKey) name.push("shift"); | ||
| if (hotkey.altKey) name.push("alt"); | ||
| name.push(); |
I added a few tests, I'm not sure they pass thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a
toHotkeyNameand agetHotKeyNamefunction in order to convert an event to a hotkey name that can then be used inside a switch statement.I also took the time to add the necessary documentation though it might not be fully complete as I didn't describe the
toHotKeyNamefunction.Fixes #46
Type of change
Please delete options that are not relevant.
How To Verify?
If you would like, you could test this feature in this sandbox.