New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixed: Incorrect index value. #32

Open

debojyotighosh wants to merge 1 commit into iansinnott:master from debojyotighosh:bugfix-incorrect_index

debojyotighosh commented May 14, 2018

Currently, index value returns odd values only (1,3,5,7...), and not values that one generally expects (0,1,2,3...). This patch fixes that.


          Bug fixed: Incorrect index value.

1ec8852

Owner

iansinnott commented May 14, 2018

@debojyotighosh thanks, that makes sense 👍

Could you add a test to make sure the indexes are passed as expected?

Test file: https://github.com/iansinnott/react-string-replace/blob/master/test.js

Owner

iansinnott commented May 14, 2018

Also, why are you using parseInt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment