Bug1 #2
Open
Bug1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPOILER ALERT
Readers of Test-Driven iOS Development may wish to try fixing #1 themselves before reading the code in this pull request.
Fixes #1
This pull request addresses the problem noted in Chapter 10 of the book and raised here as #1, that the application introduces duplicate entries in a topic's question list if it loads the same question multiple times.
Further work
While the pull request addresses the reported problem, it uncovers another; the data model in the app can't distinguish different versions of an entity. As an example, two questions that are in the same place (i.e. have the same ID) but different time (i.e. one represents a future edit of the other) cannot be told apart.