feat(PointCloud): increase range of picking to u32 #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloTheDrunk
force-pushed
the
larger_cloud_picking
branch
from
66c2e5d
to
49d41be
Compare
|
I don't know where the functional test errors are coming from, I can't replicate them locally so I'm guessing (hoping) it's a toolchain problem and not on my end |
HoloTheDrunk
force-pushed
the
larger_cloud_picking
branch
from
49d41be
to
4c5e66c
Compare
HoloTheDrunk
force-pushed
the
larger_cloud_picking
branch
from
4c5e66c
to
58a43d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the picking IDs from u16 to u32.
Motivation and Context
Effectively eliminates the possibility of not having enough IDs to perform picking until GPUs start having 32GB+ of VRAM.
Tested on Firefox 123.0 (64-bit) on Ubuntu Linux 22.04.4 LTS x86_64