Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #2226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update issue templates #2226

wants to merge 1 commit into from

Conversation

AnthonyGlt
Copy link
Contributor

@AnthonyGlt AnthonyGlt commented Nov 10, 2023

2 issue templates:

  • Bug <- The old issue template is used
  • Proposal <- Template for new feature or ideas

@mgermerie
Copy link
Contributor

Thanks for this addition. Wouldn't we need to delete the current .github/ISSUE_TEMPLATE.md file as well ?

@AnthonyGlt
Copy link
Contributor Author

We can keep it, it will be used in this case:
image
We could also edit it
I'll try to remove it, I think an other template will be shown

Copy link
Contributor

@Desplandis Desplandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, I added a few comments on the proposed proposal request!
We could discuss it in this issue. =)


## Context
<!--- A description of the feature and why this feature could be interesting to implement in iTowns! -->
<!--- Current state of iTowns vs. state after implementation -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The impacting changes part shall be in a dedicated part. See comment below.

## Context
<!--- A description of the feature and why this feature could be interesting to implement in iTowns! -->
<!--- Current state of iTowns vs. state after implementation -->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could include an optional sub-part describing the state-of-the-art of such functionality or its use in other tools.

<!--- Providing context helps us come up with a solution that is most useful in the real world -->
<!--- Could be screenshot of the feature implemented somewhere else or results/stats/poc showing the potential result -->

## Proposal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Proposal" shall be renamed to "Implementation" and shall be an optional part if there is no proposed implementation. Add a comment (e.g. "Describe the proposed implementation (PR, pseudo-code and/or diagrams)").

The idea is to have 2 main parts of the proposal (a functional and technical part). The optional is mandatory (and IMHO the important part) and the technical optional but is mandatory if there is an implementation proposed/an open PR.

<!--- Current state of iTowns vs. state after implementation -->


## Expected behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Expected behavior" shall be renamed to "Description of the proposal" (in terms of functionnality).

## Potential Solutions
<!--- Things that could be done to avoid the mentioned problems -->

## Identified use-cases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cases shall be on top (below or as a sub-part of "Description of the Proposal")!
This list will be updated by the assigned person given the comments on the proposal.

<!--- Things that should be done in iTowns to implement this feature -->

## Potential Problems
<!--- Things that could be problematic with this feature or its implementation -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO there could be multiple potential solutions/problems.


## Identified use-cases
<!--- Define in which context this feature could be useful for the user -->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a proposed implementation, there should be a study of the impact (either by the person proposing or one of the maintainer) as a PR, pseudo-code and/or diagrams.

---

<!--- Provide a general summary of the proposal in the Title above -->
This issue is a **feature proposal**. Feel free to upvote (with :+1: ), comment and provide your use-cases if you're interested by this feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an important notice that a proposal = one and only one feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants