Harmonize Dispose Function Names #2165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to prevent breaking changes
…ions in classes that extend layer
…essages to old methods refactor(api): rename delete methods to dispose refactor(scheduler): rename cache.clear to dispose and cache.delete to remove refactor: add console warning messages to old dispose methods in order to prevent breaking changes
…ions in classes that extend layer
…ther layer dispose methods
…e.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose()
…er has it in it's own dispose method
…e.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose()
…cause the parent does it
…Cache parameter included
…e.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose()
…e.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose()
…essages to old methods refactor(api): rename delete methods to dispose refactor(scheduler): rename cache.clear to dispose and cache.delete to remove refactor: add console warning messages to old dispose methods in order to prevent breaking changes
…ions in classes that extend layer
…r to prevent breaking changes
…ions in classes that extend layer
…ther layer dispose methods
…er has it in it's own dispose method
…cause the parent does it
…Cache parameter included
….com/jamesmyose/itowns into harmonize-dispose-names-third-backup
jamesmyose
changed the title
jamesmyose
changed the title
|
@ftoromanoff Hey, so I was able to get a rebase working, It looks like it did rebase successfully, but the commits still show the original PR's commits and the new ones on top. I also can't guarantee that all the changes were transferred correctly. I do have a backup branch so I try it again if necessary. Alternatively, though obviously I don't prefer this, I can create a new branch and manually make all the changes into a new commit. |
|
Hello and than you ! |
author James Myose <jmyose@live.com> 1675463912 -0600 committer James Myose <jmyose@live.com> 1691295911 -0500 parent 9370312 author James Myose <jmyose@live.com> 1675463912 -0600 committer James Myose <jmyose@live.com> 1691295549 -0500 refactor(Cache, Layer): Rename Cache.clear() to Cache.dispose(), Cache.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose() refactor(Cache, Layer): Rename Cache.clear() to Cache.dispose(), Cache.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose() refactor(api, scheduler): rename delete methods and add deprecation messages to old methods refactor(api): rename delete methods to dispose refactor(scheduler): rename cache.clear to dispose and cache.delete to remove refactor: add console warning messages to old dispose methods in order to prevent breaking changes refactor: remove deprecated function comments and remove delete functions in classes that extend layer refactor: add console warning messages to old dispose methods in order to prevent breaking changes refactor: remove deprecated function comments and remove delete functions in classes that extend layer refactor: clear cache in layer.dispose and correctly clear cache in other layer dispose methods refactor: remove this.cache.dispose calls in other layers because layer has it in it's own dispose method chore: fixing console.warn typos fix(Layer): call the correct dispose method when the layer is disposed fix: remove if checks for clearCache in each Layer dispose methods because the parent does it fix: make the layer dispose methods call super.dispose with the clearCache parameter included chore: update CONTRIBUTORS.md and try to prevent merge conflicts refactor(Cache, Layer): Rename Cache.clear() to Cache.dispose(), Cache.delete() to Cache.remove() and Layer.delete() to Layer.dispose() BREAKING CHANGE: Cache.clear() has been renamed to Cache.dispose() BREAKING CHANGE: Cache.delete() has been renamed to Cache.remove() BREAKING CHANGE: Layer.delete() has been renamed to Layer.dispose() refactor(api, scheduler): rename delete methods and add deprecation messages to old methods refactor(api): rename delete methods to dispose refactor(scheduler): rename cache.clear to dispose and cache.delete to remove refactor: add console warning messages to old dispose methods in order to prevent breaking changes refactor: remove deprecated function comments and remove delete functions in classes that extend layer refactor(api): rename delete methods to dispose refactor: add console warning messages to old dispose methods in order to prevent breaking changes refactor: remove deprecated function comments and remove delete functions in classes that extend layer refactor: clear cache in layer.dispose and correctly clear cache in other layer dispose methods refactor: remove this.cache.dispose calls in other layers because layer has it in it's own dispose method chore: fixing console.warn typos fix(Layer): call the correct dispose method when the layer is disposed fix: make the layer dispose methods call super.dispose with the clearCache parameter included chore: update CONTRIBUTORS.md and try to prevent merge conflicts
….com/jamesmyose/itowns into harmonize-dispose-names-third-backup
|
@ftoromanoff Hey, so I merged the most recent changes into my master branch and then I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This is work on #1937. I found some delete functions that I could change, but I was unsure about changing anything else.
This PR should have the same code as #1938. Because the commit history was flawed, I rebased this branch based on the current master