Fix /usr/libexec/cydia/firmware.sh not finishing and iOS 9 compat #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: The new firmware.sh version will retry `gssc` process until it doesn't return a string in both stderr and stdout that contains `(null)`. Since Introspy hooks into all processes, Introspy is injected into `gssc`, it doesn't find a bundle ID and thus prints `(null)` in the logs and causing firmware.sh to keep retrying forever using battery and blocking firmware.sh's completion. Fixed this by getting the process name instead if the bundle ID is not found. I understand this is a problem in firmware.sh also and will occur with other tweaks that print `(null)` into the logs and that should be fixed, too.
|
This pull request now includes the filter plist to make it work in iOS 9. |
radj
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
The new firmware.sh version will retry
gsscprocess until it doesn't return a string in both stderr and stdout that contains(null). Since Introspy hooks into all processes, Introspy is injected intogssc, it doesn't find a bundle ID and thus prints(null)in the logs and causing firmware.sh to keep retrying forever using battery and blocking firmware.sh's completion.Fixed this by getting the process name instead if the bundle ID is not found. I understand this is a problem in firmware.sh also and will occur with other tweaks that print
(null)into the logs and that should be fixed, too.