Use separate pixmaps for each edge of a container (#3479) #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great attempt but this creates artifacts for me in the borders. Before: After: |
orestisfl
requested changes
May 17, 2024
| * | ||
| */ | ||
| void sparse_surface_copy(sparse_surface_t *src_sparse, surface_t *dest, double src_x, double src_y, | ||
| double dest_x, double dest_y, double width, double height) { |
There was a problem hiding this comment.
width and height ignored here.
orestisfl
added
the
waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #3479.
i3 currently allocates one big pixmap for an entire window, but only draws on the edges of the pixmap. This code allocates four separate pixmaps for each edge of the window (a 'sparse surface'), thereby using less memory.
To ensure 'correctness', any drawing operation is performed on each of the four edge pixmaps, so that any operation that crosses pixmap boundaries will be drawn correctly. Note that any draws outside the pixmap boundary will just be clipped. This may not be the most efficient way to handle this, and could possibly be optimized, but I was going for correctness in this case. I'm open to suggestions on this...