Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border dimensions with hide_edge_borders #5193

Closed
wants to merge 1 commit into from
Closed

Conversation

gnif
Copy link

@gnif gnif commented Oct 9, 2022

If the borders are hidden by default, applications are incorrectly told they have borders, this PR corrects this.

If the borders are hidden by default, applications are incorrectly told they have borders, this PR corrects this.
@gnif
Copy link
Author

gnif commented Oct 9, 2022

I suspect this PR needs further work by someone that is more familiar with the i3 code base. There are some issues here still such as a floating window with borders will now report no borders. Also windows with a MOTIF hint for no decorations are told they have borders still.

While as per spec it's reasonable that the values are estimated, it's not reasonable that they are completely wrong when i3 knows if there should be borders or not.

@gnif gnif marked this pull request as draft October 9, 2022 15:40
@orestisfl
Copy link
Member

I don't think this is more correct, hide_edge_borders is conditional, it only applies when there are no other windows in the configured direction.

While as per spec it's reasonable that the values are estimated, it's not reasonable that they are completely wrong when i3 knows if there should be borders or not.

Is there any real-life usecase where this matters?

Closing but let me know if I misunderstood something.

@orestisfl orestisfl closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants