Allow splitting into any kind of layout

[AMDmi3]

This should solve #4207, I've successfully tested this as a patch to 4.18.2.

This change introduces tabbed, stacking, stacked modes to split command in a backward compatible way (t still works as toggle).

Additionaly, this changes behavior which replaces the layout of current container (instead of creating a nested container) if the container only has one child: while before it only worked for splits, now it works for all layouts which is IMO more consistent.

Fixes #4207
Closes #3001

[AMDmi3]

There seem to be a broken test related to

Additionaly, this changes behavior which replaces the layout of current container (instead of creating a nested container) if the container only has one child: while before it only worked for splits, now it works for all layouts which is IMO more consistent.

Can revert the bahavior or fix the test, depending on which behavior is desired.

[orestisfl]

There seem to be a broken test related to

Additionaly, this changes behavior which replaces the layout of current container (instead of creating a nested container) if the container only has one child: while before it only worked for splits, now it works for all layouts which is IMO more consistent.

Can revert the bahavior or fix the test, depending on which behavior is desired.

So, the behavior of layout stacked is affected? This is certainly not desirable.

[AMDmi3]

So, the behavior of layout stacked is affected?

It is not, it only affects splits.

[orestisfl]

Sounds good, this will also fix #3001.

Can you fix the test and include new ones that test the new behavior please?

[AMDmi3]

Sorry, short on time right away, will do this next week

[wlhlm]

Thanks for taking a stab at implementing this! ❤️ This fixes one of the annoyances I've had with i3's windowing.

What follows is a patch that is better handled in a separate PR

Here is a patch that draws indicators for the new splits (as it already does for horizontal and vertical). For stacked, it draws the indicator over the top border, mirroring the vertical split indicator. I don't this think will be confused with the vertical split as that will always split at the bottom (as far as I know), opposite of where the stacked split indicator would be drawn. The tabbed indicator also draws over the top border, but only for half the width, sort of mimicking a tab.

diff --git a/src/x.c b/src/x.c
index def79ef2..5348764c 100644
--- a/src/x.c
+++ b/src/x.c
@@ -588,6 +588,12 @@ void x_draw_decoration(Con *con) {
             } else if (p->parent_layout == L_SPLITV) {
                 draw_util_rectangle(&(con->frame_buffer), p->color->indicator,
                                     br.x, r->height + (br.height + br.y), r->width + br.width, -(br.height + br.y));
+            } else if (p->parent_layout == L_STACKED) {
+                draw_util_rectangle(&(con->frame_buffer), p->color->indicator,
+                                    br.x, br.y, r->width + br.width, br.height);
+            } else if (p->parent_layout == L_TABBED) {
+                draw_util_rectangle(&(con->frame_buffer), p->color->indicator,
+                                    br.x, br.y, (r->width + br.width) / 2, br.height);
             }
         }
     }

Here is a preview with increased border size. Tabbed split is on the left, and stacked on the right:

[Airblader]

@wlhlm Your patch seems to fit issue #1067 more than this PR.

[wlhlm]

Huh, I totally forgot to check if this has been discussed before. Though I'm not surprised that it has.