stream: Check the key before invoking g_hash_table_remove #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that I hit a bug where pa_stream_unref would call g_hash_table_remove with a NULL key. Thanks for the lightweight and smooth error handling from Glib, g_hash_table_remove generated an ABORT call, crashing some Unity3D games I was trying to start. Now, you also CANNOT call g_hash_table_lookup with a NULL key. That also generate a crash... Ugh... So, yeah, we first check that the key is not 0, then check if the key is actually inside the Hash table and THEN remove it. Note, here's my ~/.asoundrc, just in case : defaults.pcm.!card Audio defaults.ctl.!card Audio Audio being : card 3: Audio [DigiHug USB Audio], device 0: USB Audio [USB Audio] Subdevices: 0/1 Subdevice #0: subdevice #0 card 3: Audio [DigiHug USB Audio], device 1: USB Audio [USB Audio i-rinat#1] Subdevices: 1/1 Subdevice #0: subdevice #0 I'm using a FiiO device for sound output. Signed-off-by: Miouyouyou (Myy) <myy@miouyouyou.fr>
|
I guess that this might not be the good way (TM) of handling such bugs. Searching for why the key is NULL at this point would be far better, but I didn't have enough time to delve into this and... the fix works ! |
|
I guess that this might also fix bug #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that I hit a bug where
pa_stream_unrefwouldcall
g_hash_table_removewith a NULL key.Thanks for the lightweight and smooth error handling from
Glib,
g_hash_table_removegenerated an ABORT call, crashingthe Unity3D games (e.g. Wizards of Legend) I was trying to start.
Now, I discovered that
g_hash_table_lookupCANNOT be called with a NULLkey. That also generate a crash... Ugh...
So, yeah, basically to avoid this bug, run the game and get some nice sound
in the headphones, here's what I did :
Note, here's my ~/.asoundrc, just in case :
Audio being a FiiO USB device where my headphones are connected to :
Signed-off-by: Miouyouyou (Myy) myy@miouyouyou.fr