Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/omit-empty-sources #386

Merged
merged 4 commits into from
May 21, 2024
Merged

feature/omit-empty-sources #386

merged 4 commits into from
May 21, 2024

Conversation

gecBurton
Copy link
Collaborator

@gecBurton gecBurton commented May 16, 2024

Context

As a user I do not want an empty source section to be displayed in addition to the explicit sources in the payload

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@gecBurton gecBurton changed the title empty source omitted feature/omit-empty-sources May 16, 2024
Copy link
Contributor

@KevinEtchells KevinEtchells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks George. This is still a good step, so approved!

@gecBurton gecBurton merged commit 446f89b into main May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants