Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies use of environment variables #381

Closed
wants to merge 16 commits into from
Closed

Simplifies use of environment variables #381

wants to merge 16 commits into from

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented May 16, 2024

Context

We're accruing lots of confusing env files and it's causing conflict.

The core principle of this change is there should only be one .env.example in the repo, which would provide sensible defaults for us to use as we write environment configurations elsewhere. Environments should be configured and stored in the place they’re needed. There is no inheritance of variables.

Changes proposed in this pull request

  • The environment variables for integration tests are set in the workflows
  • env_file is removed from docker-compose as .env is loaded anyway, and each deployment/testing location ensures the right vars are in the environment
  • The environment variables for local unit tests are stored in pyproject.toml and used with pytest-env
  • User preferences and local settings (the same thing now) are in .env, copied and edited from .env.example

Guidance to review

  • Run every single make test-* command and confirm they all work
  • Ensure you're happy with the env variables I've set in docker-compose
  • Ensure you're happy with the env variables I've set in your pyproject.toml

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@wpfl-dbt
Copy link
Collaborator Author

Closing this PR as it's just not going to make it in and spike/envs still exists if we want to go down that route.

@wpfl-dbt wpfl-dbt closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant