Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the members position to have the same order in c and c++ #1518

Merged
merged 4 commits into from Mar 13, 2023
Merged

Change the members position to have the same order in c and c++ #1518

merged 4 commits into from Mar 13, 2023

Conversation

mick111
Copy link
Contributor

@mick111 mick111 commented Feb 24, 2023

To solve issue #1517 about order of members of structures RGBMatrix:Options and RGBLedMatrixOptions

@hzeller
Copy link
Owner

hzeller commented Feb 27, 2023

Thanks, somehow this got messed up. Thanks for the fix.
One request though: can you move the c-struct members around instead of the c++ members ?
I want to keep ABI compatibility in the c++ lib.

@hzeller hzeller merged commit ac05820 into hzeller:master Mar 13, 2023
@hzeller
Copy link
Owner

hzeller commented Mar 13, 2023

Thanks, merged!

andrewsiemer pushed a commit to andrewsiemer/rpi-rgb-led-matrix that referenced this pull request Nov 7, 2023
@mick111
Change the members position to have the same order in c and c++ (hzel…
1b2455b 
…ler#1518)

Change the members position to have the same order in c and c++. Change in the C API to keep the C++ API with the fixed ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mick111 @hzeller