Python bindings for FrameCanvas::Serialize/Deserialize #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this enables usage like in cpp content-streamer
ledvinap
reviewed
Oct 24, 2022
| @@ -53,6 +53,12 @@ cdef class Canvas: | |||
| b = (pixel >> 16) & 0xFF | |||
| my_canvas.SetPixel(xstart+col, ystart+row, r, g, b) | |||
|
|
|||
| cdef class FrameData: | |||
| cdef const char *__getData(self) except +: | |||
There was a problem hiding this comment.
Suggested change
| cdef const char *__getData(self) except +: | |
| cdef const char *__getData(self) except NULL: |
except + means that code can throw C++ exception
except NULL - check exception state if returned value is NULL
| def Serialize(self): | ||
| cdef const char* data | ||
| cdef size_t length | ||
| (<cppinc.FrameCanvas*>self.__getCanvas()).Serialize(&data, &length) |
There was a problem hiding this comment.
I'm afraid that this won't work for your purpose. Serialize just returns pointer to internal frame representation (one instance per FrameCanvas), it does not copy it.
One option is to implement buffer protocol for FrameCanvas and then use python for memory management. I'll post PR soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables usage like in cpp content-streamer