weekStartsOn propagation #523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapshots have been updated and the props that disappeared are the defalt props which are passed now from within the component
iamalextodoran
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyDescription
Describe your pr here.
Pass the
weekStartsOnprop toDefinedRange. Fixes the inconsistency between theCalendarand theDefinedRange.Also changed the order of
StaticRangesto make them appear chronologically.Last Month, Last Week, Yesterday, Today, This Week, This Month. If this poses a problem I can fix it, but I needed that order, so I made it the default (my bad not to separate commits).