This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Event Processor SDK #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This RFC proposes extensions to the Sawtooth SDK's to support event processing. These events are emitted by the validator on block commits and can be subscribed to via client messages. These SDK extensions propose a simplified abstraction on top of these client messages in order to provide a simple model for handling the events. This API is akin to the Transaction Handler/Transaction Processor API's. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
peterschwarz
requested review from
agunde406,
dcmiddle,
ineffectualproperty,
jsmitchell,
TomBarnes and
vaporos
as code owners
arsulegai
reviewed
Jul 3, 2019
| { ... } | ||
|
|
||
| impl EventProcessor { | ||
| pub fn new(validator_endpoint: String) -> Self |
There was a problem hiding this comment.
[nitpick]: Missing {} has broken the syntax highlighter
| -> Self | ||
| { ... } | ||
|
|
||
| fn with_regex_filter( |
There was a problem hiding this comment.
[Thinking out loud]: Can this be trait object passed to a function like "with_filter()", where is either regex or simple or something else coming up later.
Fix code snippet for proper syntax highlighting. Signed-off-by: Peter Schwarz <pschwarz@bitwise.io>
arsulegai
approved these changes
Jul 10, 2019
danintel
reviewed
Jul 12, 2019
There was a problem hiding this comment.
I assume this documents existing event handling. I see where you describe creating a subscription, then you jump to event handling. Missing is any description of how/where to send the subscription, and an API to listen to the event subscription response.
A Rust example would be nice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC proposes extensions to the Sawtooth SDK's to support event
processing. These events are emitted by the validator on block commits
and can be subscribed to via client messages.
These SDK extensions propose a simplified abstraction on top of these
client messages in order to provide a simple model for handling the
events. This API is akin to the Transaction Handler/Transaction
Processor API's.
Signed-off-by: Peter Schwarz pschwarz@bitwise.io