Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto complete options for as command and closure command. #6734

Merged
merged 15 commits into from May 13, 2024

Conversation

xuanyanwow
Copy link
Member

No description provided.

@xuanyanwow xuanyanwow self-assigned this May 8, 2024
@xuanyanwow xuanyanwow marked this pull request as draft May 8, 2024 09:01
@huangdijia
Copy link
Member

不建议加这个功能,带来的问题可能更多

@xuanyanwow xuanyanwow changed the title Optimize as command Auto complete options for as command and closure command. May 13, 2024
huangdijia
huangdijia previously approved these changes May 13, 2024
@xuanyanwow xuanyanwow marked this pull request as ready for review May 13, 2024 08:26
@xuanyanwow
Copy link
Member Author

Auto define option for params of int float string bool type.

Example

#[AsCommand(signature: 'eeeee')]
public function test(string $name, int $age)
{
    dump($age, $name);
}

And then we can use php bin/hyperf.php eeeee --name=test --age=999 to run it.

@limingxinleo limingxinleo merged commit e2fb772 into hyperf:master May 13, 2024
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants