feat: Give more space to Session Player when expanded #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63d8675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svc-shorpo
force-pushed
the
sr/fullscreen
branch
from
14b2b59
to
78afa55
Compare
MikeShi42
previously approved these changes
Dec 20, 2023
| @@ -1978,6 +1980,8 @@ function SidePanelHeader({ | |||
| parsedProperties?.['process.tag.rum.sessionId'] ?? | |||
| sessionId; | |||
|
|
|||
| const playerExpanded = useAtomValue(playerExpandedAtom); | |||
There was a problem hiding this comment.
mega nit: I think it'd make more sense if we named this as like "collapseEventContext" or something right? I can imagine technically any subpanel might want in the future to be able to collapse the event context around it. Though not terribly familiar with jotai and it seems like the data flow is somewhat inverted to what I'm used to.
|
@svc-shorpo I think we can merge this once the conflict is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-12-19.at.8.08.25.PM.mov