Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Vault Raft auto-snapshot endpoints. #1169

Merged
merged 3 commits into from
May 7, 2024

Conversation

tot19
Copy link
Contributor

@tot19 tot19 commented May 6, 2024

These endpoints are only accessible within Vault Enterprise and were introduced in version 1.6.

Adding methods, documentation and integration tests for the following endpoints - read raft auto snapshot status, read raft auto snapshot config, list raft auto snapshot configs, create or update raft auto snapshot config, and delete raft auto snapshot config

Resolves #1150

These endpoints are only accessible within Vault Enterprise and were introduced in version 1.6.

Adding methods, documentation and integration tests for the following endpoints - read raft auto snapshot status, read raft auto snapshot config, list raft auto snapshot configs, create or update raft auto snapshot config, and delete raft auto snapshot config
@tot19 tot19 requested a review from a team as a code owner May 6, 2024 08:45
@tot19

This comment was marked as duplicate.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 87.54%. Comparing base (b1f62ac) to head (e821c9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   87.81%   87.54%   -0.28%     
==========================================
  Files          67       67              
  Lines        3267     3283      +16     
==========================================
+ Hits         2869     2874       +5     
- Misses        398      409      +11     
Files Coverage Δ
hvac/api/system_backend/raft.py 36.58% <31.25%> (-3.42%) ⬇️

@@ -1,7 +1,7 @@
#!/usr/bin/env python
"""Raft methods module."""
from hvac import adapters, utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this reordered? was that done by black or something else? If so, what version of black?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was done by my local black "format on save" config ... Sorry about that. I have reverted and pushed up a new commit

@briantist briantist self-assigned this May 6, 2024
@briantist briantist changed the title Issue 1150 - adding support for Vault Raft auto-snapshot endpoints. add support for Vault Raft auto-snapshot endpoints. May 6, 2024
@briantist briantist added enhancement a new feature or addition system backend generally related to the Vault system backend routes minor Used as part of release-drafter's version-resolver configuration labels May 6, 2024
@briantist briantist added this to the 2.3.0 milestone May 6, 2024
@briantist
Copy link
Contributor

from #1150

Just opened the PR .. Only thing I would add to the PR notes is that the ent versions 1.7 and 1.8 do technically support these endpoints; however, they appear to not be using raft storage in the test config.

https://github.com/tot19/hvac/actions/runs/8966262561/job/24621406473

Yes that's true, raft is not used in the test Vault instances, the multi-node Vault test "clusters" use consul in CI right now.

@briantist briantist merged commit 96bb9a3 into hvac:main May 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition minor Used as part of release-drafter's version-resolver configuration system backend generally related to the Vault system backend routes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coverage for automatic snapshot route
3 participants