update codecov to v4 and use upload token #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
CI/CD
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
+ Coverage 87.66% 87.68% +0.01%
==========================================
Files 66 66
Lines 3227 3231 +4
==========================================
+ Hits 2829 2833 +4
Misses 398 398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov v3 has stopped working properly, we will update to v4, but v4 does not support tokenless uploading except on PRs from forks, so I have also added the token as a repository secret (also in dependabot secrets).
v3action fails because of missing token codecov/codecov-action#1359I've also set it so that CI fails if there's an error reporting coverage. I hadn't even noticed the issue until now because CI was passing.
Closes #1134