Make integration tests more reliable #1153
Conversation
From time to time, some integration tests fail with connection errors. Tests are made more reliable by retrying upon connection failures. Closes: #1141
There was a problem hiding this comment.
I HATE vault and ssl certs. Yes I know I wrote large portions of its hvac implementation but I still hate them for their complexity.
This is beautiful code! But I wonder if there are other places that this redundancy might be added to hvac? Should we be more proactive in building requests.Session()'s in other places?
Honestly though nice code.
There was a problem hiding this comment.
Thanks! To be honest, I do not have a high level picture about how requests is used in hvac. Maybe more experienced contributors can have a comment.
There was a problem hiding this comment.
I have had plans to incorporate retries into the hvac adapter system so that a library user does not need to create a custom session, but it was going to be after making some big changes to the adapter system which have been on hold:
There was a problem hiding this comment.
Sessions and certs are hard. This is a great addition.
briantist
added
patch
From time to time, some integration tests fail with connection errors. Tests are made more reliable by retrying upon connection failures.
Closes: #1141