Add sts_region parameter to auth.aws.configure #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
reviewed
Feb 21, 2024
hvac/api/auth_methods/aws.py
Outdated
| @@ -26,6 +26,7 @@ def configure( | |||
| endpoint=None, | |||
| iam_endpoint=None, | |||
| sts_endpoint=None, | |||
| sts_region=None, | |||
There was a problem hiding this comment.
We'll need to move this to the end of the parameter list to avoid breaking users setting their arguments positionally.
briantist
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 87.66% 87.66%
=======================================
Files 66 66
Lines 3227 3227
=======================================
Hits 2829 2829
Misses 398 398
|
|
Hi @ewanoomen , could you fix the linting errors and move the parameter to the end of the list? I think we could get this merged pretty quickly. |
Sorry for the late reply, I've moved the parameter and linting should be fixed as well |
briantist
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the sts_region parameter to auth.aws.configure to configure the parameter mentioned here: https://developer.hashicorp.com/vault/api-docs/auth/aws#sts_region
Resolves #1137