Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add totp parameter for Okta login #1110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

voldemortensen
Copy link

closes #936

@voldemortensen voldemortensen requested a review from a team as a code owner December 5, 2023 05:44
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1110 (338a97d) into main (7db7de1) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   87.12%   87.10%   -0.03%     
==========================================
  Files          64       64              
  Lines        3162     3164       +2     
==========================================
+ Hits         2755     2756       +1     
- Misses        407      408       +1     
Files Coverage Δ
hvac/api/auth_methods/okta.py 97.95% <50.00%> (-2.05%) ⬇️

voldemortensen and others added 2 commits December 4, 2023 23:32
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update auth.okta.login method to use TOTP parameter
2 participants