Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting via ruff #1059

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add linting via ruff #1059

wants to merge 15 commits into from

Commits on Sep 15, 2023

  1. Add Ruff package: 

    Because Ruff uses 0.0.* versioning at the moment, I am using the `~` version
specifier instead of `^`.
    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1939946 View commit details
    Browse the repository at this point in the history

  2. Add ruff to CI and Makefile: 

    Currently I am only checking `hvac`, though we should probably check `tests` as
well. Also, at some point we will probably want to drop flake8, but for now I
will leave it as is.
    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7528a95 View commit details
    Browse the repository at this point in the history

  3. Convert format calls to fstrings (UP032)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a3a0c66 View commit details
    Browse the repository at this point in the history

  4. Fix naive UTC datetime (DTZ003)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    fb5c0f1 View commit details
    Browse the repository at this point in the history

  5. Remove shebangs (EXE001)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    bddf644 View commit details
    Browse the repository at this point in the history

  6. Simplify dict/tuple/generators

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e5a833d View commit details
    Browse the repository at this point in the history

  7. Simplify return and raise statements

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a67d26d View commit details
    Browse the repository at this point in the history

  8. Remove mutable default arguments (B006)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    97d38f9 View commit details
    Browse the repository at this point in the history

  9. Remove unused args (ARG002)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    cf082da View commit details
    Browse the repository at this point in the history

  10. Replace mutable class list with tuple (RUF012)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7e33cd3 View commit details
    Browse the repository at this point in the history

  11. Remove ambiguous unicode characters from docstring (RUF002)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f19ff19 View commit details
    Browse the repository at this point in the history

  12. Don't use % in log statements (G002)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8e1b04d View commit details
    Browse the repository at this point in the history

  13. Simplify elif (PLR5501)

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    64694eb View commit details
    Browse the repository at this point in the history

  14. Reformat with black

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0c91ae1 View commit details
    Browse the repository at this point in the history

  15. Fix failing test

    @dosisod
    dosisod committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ef00d8e View commit details
    Browse the repository at this point in the history