-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 & 3.7, Add Python 3.11, bump some dependencies #1048
Merged
briantist
merged 19 commits into
hvac:main
from
briantist:maintenance/python-testing-packaging
Sep 10, 2023
Merged
Drop Python 3.6 & 3.7, Add Python 3.11, bump some dependencies #1048
briantist
merged 19 commits into
hvac:main
from
briantist:maintenance/python-testing-packaging
Sep 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
CI/CD
related to CI/CD (not necessarily tests)
dependencies
Pull requests that update a dependency file
breaking-change
major
Used as part of release-drafter's version-resolver configuration
maintenance
General technical debt
labels
Sep 9, 2023
briantist
force-pushed
the
maintenance/python-testing-packaging
branch
from
September 9, 2023 16:28
f782f05
to
844b200
Compare
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 65 65
Lines 3135 3135
=======================================
Hits 2665 2665
Misses 470 470 |
briantist
changed the title
Maintenance/python testing packaging
Drop Python 3.6 & 3.7, Add Python 3.11, bump some dependencies
Sep 9, 2023
kaypeter87
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kaypeter87 thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
CI/CD
related to CI/CD (not necessarily tests)
dependencies
Pull requests that update a dependency file
maintenance
General technical debt
major
Used as part of release-drafter's version-resolver configuration
tests
related to tests (not necessarily CI/CD)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make a number of changes around python, dependencies, & CI/CD
Resolves #999
Supersedes #1005
poetry
version to1.6.1
pyproject.toml
dev dependencies to newer poetry group formatjinja2
as an explicit dev dependency so we can pin it to deal with old docs dependenciesactions/checkout
tov4
and disable showing progress(all TODOs are for new issues/PRs)
About Python 3.12
I figured I'd add it to the matrix if we could (pre-release) just to be prepared. Current blocker (haven't explored all of them) is the
greenlet
package which is a dependency ofsqlalchemy
(viaFlask-SQLAlchemy
) used in our tests.It seems
greenlet
has fixed those 3.12 issues but they've only been released in pre-release versions so far, so when 3.0.0 is out we should be able to revisit this, as long as the packages we actually use update their dependencies too.