Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 & 3.7, Add Python 3.11, bump some dependencies #1048

Merged
merged 19 commits into from
Sep 10, 2023

Conversation

briantist
Copy link
Contributor

@briantist briantist commented Sep 9, 2023

This PR will make a number of changes around python, dependencies, & CI/CD

Resolves #999
Supersedes #1005

(all TODOs are for new issues/PRs)

About Python 3.12

I figured I'd add it to the matrix if we could (pre-release) just to be prepared. Current blocker (haven't explored all of them) is the greenlet package which is a dependency of sqlalchemy (via Flask-SQLAlchemy) used in our tests.

It seems greenlet has fixed those 3.12 issues but they've only been released in pre-release versions so far, so when 3.0.0 is out we should be able to revisit this, as long as the packages we actually use update their dependencies too.

@briantist briantist added CI/CD related to CI/CD (not necessarily tests) dependencies Pull requests that update a dependency file breaking-change major Used as part of release-drafter's version-resolver configuration maintenance General technical debt labels Sep 9, 2023
@briantist briantist added this to the 2.0.0 milestone Sep 9, 2023
@briantist briantist self-assigned this Sep 9, 2023
@briantist briantist force-pushed the maintenance/python-testing-packaging branch from f782f05 to 844b200 Compare September 9, 2023 16:28
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #1048 (6bac585) into main (6ae1d21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files          65       65           
  Lines        3135     3135           
=======================================
  Hits         2665     2665           
  Misses        470      470           

@briantist briantist changed the title Maintenance/python testing packaging Drop Python 3.6 & 3.7, Add Python 3.11, bump some dependencies Sep 9, 2023
@briantist briantist added the tests related to tests (not necessarily CI/CD) label Sep 9, 2023
@briantist briantist marked this pull request as ready for review September 9, 2023 20:57
@briantist briantist requested a review from a team as a code owner September 9, 2023 20:57
Copy link

@kaypeter87 kaypeter87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briantist
Copy link
Contributor Author

@kaypeter87 thanks for reviewing!

@briantist briantist merged commit 71efa46 into hvac:main Sep 10, 2023
33 checks passed
@briantist briantist deleted the maintenance/python-testing-packaging branch September 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change CI/CD related to CI/CD (not necessarily tests) dependencies Pull requests that update a dependency file maintenance General technical debt major Used as part of release-drafter's version-resolver configuration tests related to tests (not necessarily CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add (official) support for Python 3.11
2 participants