Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain build compat with py3.6 #1019

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

briantist
Copy link
Contributor

CI is failing now after merging #1015 , only on python 3.6, even though CI was passing with the PR contents. I believe this might have something to do with changes made in #1016 which was merged shortly before. The CI on that one was also passing, but the sdsist installation tests didn't exist then, so I think this failure is a combination of the issues.

Failure:

The error looks like what's described here:

that despite poetry supporting python 3.6, poetry-core had already dropped it. I don't really see how the changes in #1016 affected that, since it didn't change the poetry core version, but I'm attempting to fix it for this one release that we're doing before we drop Python 3.6 in 2.0 soon.

@briantist briantist added CI/CD related to CI/CD (not necessarily tests) skip-changelog will not be shown in the auto-generated changelog tests related to tests (not necessarily CI/CD) maintenance General technical debt labels Jun 27, 2023
@briantist briantist added this to the 1.2.0 milestone Jun 27, 2023
@briantist briantist self-assigned this Jun 27, 2023
@briantist
Copy link
Contributor Author

it looks like my suggested fix was the exact wrong thing to do; I guess it forced using the incompatible core version to all version of python... I may try to revert the conversion to the group syntax for poetry and then we'll bring it back after 3.6 is dropped..

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1019 (7201f84) into main (f58d1a2) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   81.79%   81.68%   -0.11%     
==========================================
  Files          65       65              
  Lines        3032     2998      -34     
==========================================
- Hits         2480     2449      -31     
+ Misses        552      549       -3     

see 7 files with indirect coverage changes

@briantist
Copy link
Contributor Author

Looks like that worked!

@briantist briantist marked this pull request as ready for review June 27, 2023 21:24
@briantist briantist requested a review from a team as a code owner June 27, 2023 21:24
Copy link
Member

@adammike adammike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M!

@briantist briantist merged commit 434f6b6 into hvac:main Jun 27, 2023
35 checks passed
@briantist briantist deleted the py36/build-compat branch June 27, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD related to CI/CD (not necessarily tests) maintenance General technical debt skip-changelog will not be shown in the auto-generated changelog tests related to tests (not necessarily CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants