Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for automatic snapshot route #1150

Closed
tot19 opened this issue Apr 8, 2024 · 2 comments · Fixed by #1169
Closed

Add coverage for automatic snapshot route #1150

tot19 opened this issue Apr 8, 2024 · 2 comments · Fixed by #1169
Labels
enhancement a new feature or addition system backend generally related to the Vault system backend routes
Milestone

Comments

@tot19
Copy link
Contributor

tot19 commented Apr 8, 2024

If ok, will open a PR for the enterprise automatic snapshots feature. API doc is here. Will add CRUD + list operations to hvac/api/system_backend/raft.py.

@briantist
Copy link
Contributor

Sounds great, please do!
I think we will not be able to run integration tests in CI due to #850 but please write tests anyway if possible so that they can be flipped on if we fix that. Also unit tests should be possible either way.

@briantist briantist added enhancement a new feature or addition system backend generally related to the Vault system backend routes labels Apr 15, 2024
@tot19
Copy link
Contributor Author

tot19 commented May 6, 2024

Apologies took me a bit to get to this - have been swamped lately.

Just opened the PR .. Only thing I would add to the PR notes is that the ent versions 1.7 and 1.8 do technically support these endpoints; however, they appear to not be using raft storage in the test config.

https://github.com/tot19/hvac/actions/runs/8966262561/job/24621406473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or addition system backend generally related to the Vault system backend routes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants