Modals Unification - P1 Buttons #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching button positions as part of unification for a better user experience. humhub/humhub-internal#236
This is a part of a larger task aimed at unifying Modals. The first step, which involves unifying button positions, has been completed to enhance the user experience. Issue tracker humhub/team_tasks#336 Project https://github.com/orgs/humhub/projects/31
Updating CL
ArchBlood
reviewed
May 5, 2024
| @@ -39,6 +39,16 @@ | |||
| </div> | |||
| <div class="modal-footer"> | |||
| <hr/> | |||
| <?= Html::button( | |||
There was a problem hiding this comment.
Why should we still use Html::button() here when you could use ModalButton::cancel()?
ArchBlood
reviewed
May 5, 2024
| ], | ||
| ] | ||
| ) ?> | ||
|
|
||
| <?= Html::a( |
There was a problem hiding this comment.
We can also change this to ModalButton::submitModal()
luke-
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch if no hotfixOther information:
This is a part of a larger task aimed at unifying Modals. The first step, which involves unifying button positions, has been completed to enhance the user experience.
NOTE: In addition to changing the button position in
protected/humhub/modules/space/views/membership/requestMembership.phpI also changed the button class frombtn-primary>btn-defaultfor the Close button.#236 #237 #238 #239 #240 #241 #242 #243
Issue tracker
https://github.com/humhub/team_tasks/issues/336
Project
https://github.com/orgs/humhub/projects/31