Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR does
PermissionActiveRecord
from which models that store permissions should derive fromPermissionActiveRecord
sgroup_id
(andcontentcontainer_id
/contentcontainer_class
) must be first in the index, as those fields are used in all queries, whilemodule_id
andpermission_id
are only used on some queries.BasePermission
andPermissionManager
group_id
also for content container groups and allowing additional group states (e.g. "read-only"/"write-only" or for states: "set-only"/"unset-only"PR Admin
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications:
Type restrictions as documented in
MIGRATE-DEV.md
The PR fulfills these requirements
develop
branch, not themaster
branch if no hotfix