-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: Introduce FindInstanceInterface
- Part 1.b: TagDependency
#6528
Draft
martin-rueegg
wants to merge
24
commits into
humhub:statable
Choose a base branch
from
metaworx:enh/new-find-interface-1-b
base: statable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enh: Introduce FindInstanceInterface
- Part 1.b: TagDependency
#6528
martin-rueegg
wants to merge
24
commits into
humhub:statable
from
metaworx:enh/new-find-interface-1-b
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-rueegg
force-pushed
the
enh/new-find-interface-1-b
branch
from
August 19, 2023 10:11
a67256e
to
419a7f1
Compare
5 tasks
* Sort profile fields on People directory filters * Update CHANGELOG-DEV.md
5 tasks
martin-rueegg
force-pushed
the
enh/new-find-interface-1-b
branch
from
September 8, 2023 09:14
419a7f1
to
2368098
Compare
…alled within a test
…ntActiveRecord class
martin-rueegg
force-pushed
the
enh/new-find-interface-1-b
branch
2 times, most recently
from
September 8, 2023 15:56
7f42ed1
to
0612dfb
Compare
martin-rueegg
force-pushed
the
enh/new-find-interface-1-b
branch
from
September 8, 2023 17:44
0612dfb
to
df87459
Compare
martin-rueegg
changed the title
Enh: Introduce FindInstanceInterface with methods to get (cached) instances - Part 1 b
Enh: Introduce FindInstanceInterface - Part 1 b: TagDependency
Sep 13, 2023
martin-rueegg
changed the title
Enh: Introduce FindInstanceInterface - Part 1 b: TagDependency
Enh: Introduce FindInstanceInterface - Part 1.b: TagDependency
Sep 13, 2023
martin-rueegg
changed the title
Enh: Introduce FindInstanceInterface - Part 1.b: TagDependency
Enh: Introduce Sep 13, 2023
FindInstanceInterface
- Part 1.b: TagDependency
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce FindInstanceInterface
Part 1.b Adding TagDependency to cached instances
FindInstanceInterface series:
FindInstanceInterface
- Part 1.a: Creating base classes #6503FindInstanceInterface
- Part 1.b: TagDependency #6528FindInstanceInterface
- Part 2: Implementing throughout the code #6463Also see:
FindInstanceInterface
- Part 1.a: Creating base classes #6503 (comment)I've found a way do enable cache dependencies while not using a serializer ...
TagDependencies
only work if a serializer is used. Either the default PHP-internal serializer, or a user-provided. If serialization is disabled, they will not work.Now since it would be unnecessary effort to serialize and unserialize runtime-cached items (which we all agree), serializing was disabled in
common.php
. This makes sense. However, the side effect of setting['serializer' => false]
is, thatTagDependencies
are disabled.My suggested solution is, that we provide a user-defined serializer (an array of a serializing and unserializing function) which in both cases just return the value as-is. As such, the cache implementation thinks it does serializing, while actually, it doesn't.
Note: This trick only works for
ArrayCache
, not e.g.FileCache
. So who ever decides to use a different Cache implementation for the runtime cache, needs to be aware of that.