Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two occurrences of the typo "confortable" to "comfortable" #1081

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jordanallred
Copy link

@jordanallred jordanallred commented Apr 8, 2024

Description

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

github-actions bot commented Apr 8, 2024

🤖 Coverage update for 81cabd6 🟢

Old New
Commit 429a0e5 81cabd6
Score 71.5407% 71.5407% (0)

@hugsy
Copy link
Owner

hugsy commented Apr 8, 2024

Hi @jordanallred

Thanks for the PR.
Can you remove the gef.md changes? That file is generated automatically so your changes there won't be correctly applied.

Copy link

github-actions bot commented Apr 8, 2024

🤖 Coverage update for 275ab5d 🟢

Old New
Commit 429a0e5 275ab5d
Score 71.5407% 71.5407% (0)

@jordanallred
Copy link
Author

Hi @jordanallred

Thanks for the PR. Can you remove the gef.md changes? That file is generated automatically so your changes there won't be correctly applied.

Done. Added a .gitignore that you can obviously delete as you see fit.

Copy link

github-actions bot commented Apr 8, 2024

🤖 Coverage update for 9ff7904 🟢

Old New
Commit 429a0e5 9ff7904
Score 71.5407% 71.5407% (0)

@hugsy hugsy added this to the 2024.05 milestone Apr 10, 2024
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove the empty line and we're good

@Grazfather
Copy link
Collaborator

This PR completely removes the md file?

@hugsy
Copy link
Owner

hugsy commented Apr 10, 2024

This PR completely removes the md file?

Yes, do you think it's needed to be left in the repo since it's may be out of sync with the one generated automatically on merge to main?

@hugsy
Copy link
Owner

hugsy commented Apr 23, 2024

@jordanallred

Please revert to commit 81cabd6 to restore gef.md - let's keep it for now.

This will make validation pass, so we can merge this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants