Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion route to client and add stop parameter where it's missing #1869

Merged
merged 4 commits into from May 23, 2024

Conversation

thomas-schillaci
Copy link
Contributor

What does this PR do?

  • Add the stop parameter to the completion route
  • Add the completion method to the python client
  • Add the stop parameter to the python client's chat method

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil

@Narsil Narsil requested a review from drbh May 8, 2024 12:56
@drbh drbh mentioned this pull request May 21, 2024
@drbh
Copy link
Collaborator

drbh commented May 21, 2024

Hi @thomas-schillaci thank you for the contribution! This looks great but has a couple linting issues, these can be resolved by running the following command.

pre-commit run --all-files

PS: it looks like the CI passes once those are resolved: #1931

@thomas-schillaci
Copy link
Contributor Author

@drbh thank you for the review, I've fixed the linting issues

Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!!

note: changes are exactly the same as #1931 and tests pass, so going to merge

@drbh drbh merged commit 629047c into huggingface:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants