Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gen_all_metrics() for Riemann exporter #194

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use gen_all_metrics() for Riemann exporter #194

wants to merge 2 commits into from

Conversation

uggla
Copy link
Collaborator

@uggla uggla commented Jul 17, 2022

  • Riemann is now using the helper functions to retrieve metrics like the prometheus exporter. This makes the code a bit shorter but mainly prevent discrepencies beetween exporter metrics.
  • Fix clippy warning coming from rust 1.62.

@uggla
feat: Refactor riemann exporters
a16e326 
- Refactor to use MetricGenerator.
@uggla
fix: Clippy warning
0df7913 
- Fix clippy warning from rust 1.62.
@uggla uggla requested a review from bpetit July 17, 2022 17:18
@bpetit bpetit added this to To do in General Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpetit bpetit Awaiting requested review from bpetit

Assignees
No one assigned
Labels
None yet
Projects
General
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@uggla