Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RDS): add rds pg sql limits data source #4802

Merged

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST=./huaweicloud/services/acceptance/rds/ TESTARGS='-run TestAccDataSourceRdsPgSqlLimits_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rds/ -v -run TestAccDataSourceRdsPgSqlLimits_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceRdsPgSqlLimits_basic
=== PAUSE TestAccDataSourceRdsPgSqlLimits_basic
=== CONT  TestAccDataSourceRdsPgSqlLimits_basic
--- PASS: TestAccDataSourceRdsPgSqlLimits_basic (813.47s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rds       813.516s

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

@houpeng80 houpeng80 force-pushed the rds_pg_sql_limits_data_source branch from cc5585c to 97a30fc Compare May 13, 2024 08:29
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 15, 2024
@github-ci-robot github-ci-robot merged commit 80967c9 into huaweicloud:master May 15, 2024
13 checks passed
@houpeng80 houpeng80 deleted the rds_pg_sql_limits_data_source branch May 15, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants