Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fgs): supplement attributes for dependency/async resources #4800

Merged
merged 1 commit into from May 23, 2024
Merged

feat(fgs): supplement attributes for dependency/async resources #4800

merged 1 commit into from May 23, 2024

Conversation

wangyuancheng01
Copy link
Contributor

@wangyuancheng01 wangyuancheng01 commented May 13, 2024 •
edited

What this PR does / why we need it:
supplement attributes for dependency/async resources.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST="./huaweicloud/services/acceptance/fgs" TESTARGS="-run TestAccAsyncInvokeConfig_basic"
...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccAsyncInvokeConfig_basic -timeout 360m -parallel 4
=== RUN   TestAccAsyncInvokeConfig_basic
=== PAUSE TestAccAsyncInvokeConfig_basic
=== CONT  TestAccAsyncInvokeConfig_basic
--- PASS: TestAccAsyncInvokeConfig_basic (84.57s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       84.675s

make testacc TEST="./huaweicloud/services/acceptance/fgs" TESTARGS="-run TestAccDependencyVersion_basic"
...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccDependencyVersion_basic -timeout 360m -parallel 4
=== RUN   TestAccDependencyVersion_basic
=== PAUSE TestAccDependencyVersion_basic
=== CONT  TestAccDependencyVersion_basic
--- PASS: TestAccDependencyVersion_basic (17.56s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       17.605s

make testacc TEST="./huaweicloud/services/acceptance/fgs" TESTARGS="-run TestAccFunctionGraphResourceDependency_basic"
...
==> Checking that code complies with gofmt requirements...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccFunctionGraphResourceDependency_basic -timeout 360m -parallel 4
=== RUN   TestAccFunctionGraphResourceDependency_basic
=== PAUSE TestAccFunctionGraphResourceDependency_basic
=== CONT  TestAccFunctionGraphResourceDependency_basic
--- PASS: TestAccFunctionGraphResourceDependency_basic (23.76s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       23.812s

@wangyuancheng01 wangyuancheng01 force-pushed the add_attributes branch 2 times, most recently from 247313a to 62be2b7 Compare May 13, 2024 02:54
@wangyuancheng01 wangyuancheng01 changed the title fix(fgs): supplement attributes for dependency/async resources feat(fgs): supplement attributes for dependency/async resources May 13, 2024
@github-actions github-actions bot removed the bugfix label May 13, 2024
@wangyuancheng01 wangyuancheng01 force-pushed the add_attributes branch 2 times, most recently from 2e81080 to 65584b1 Compare May 15, 2024 03:29
@github-actions github-actions bot added size/XS and removed size/S labels May 15, 2024
Lance52259
Lance52259 reviewed May 21, 2024
View reviewed changes
docs/resources/fgs_async_invoke_configuration.md Outdated
@@ -92,6 +92,10 @@ In addition to all arguments above, the following attributes are exported:

* `id` - Specifies a resource ID in UUID format.

* `created_at` - The creation time of the asynchronous invocation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `created_at` - The creation time of the asynchronous invocation.
* `created_at` - The creation time of the asynchronous invocation, in RFC3339 format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wangyuancheng01 wangyuancheng01 force-pushed the add_attributes branch 3 times, most recently from dcd0747 to c7b8925 Compare May 21, 2024 03:22
@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2024
github-ci-robot
github-ci-robot approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 8a7bfc6 into huaweicloud:master May 23, 2024
14 checks passed
@wangyuancheng01 wangyuancheng01 deleted the add_attributes branch May 23, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance52259 Lance52259 Lance52259 left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wangyuancheng01 @Lance52259 @github-ci-robot