Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apig): add new datasource to get list of custom authorizers #4794

Merged
merged 1 commit into from May 23, 2024

Conversation

wangyuancheng01
Copy link
Contributor

@wangyuancheng01 wangyuancheng01 commented May 11, 2024

What this PR does / why we need it:
add new datasource to get list of custom authorizers.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST="./huaweicloud/services/acceptance/apig" TESTARGS="-run TestAccDataSourceCustomAuthorizers_basic"
...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run TestAccDataSourceCustomAuthorizers_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCustomAuthorizers_basic
=== PAUSE TestAccDataSourceCustomAuthorizers_basic
=== CONT  TestAccDataSourceCustomAuthorizers_basic
--- PASS: TestAccDataSourceCustomAuthorizers_basic (572.95s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      572.995s

"identity": {
Type: schema.TypeList,
Computed: true,
Description: `All identity that match the filter parameters.`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: `All identity that match the filter parameters.`,
Description: `The parameter identities of the custom authorizer.`,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-ci-robot
Copy link
Collaborator

This PR needs rebase.

@wangyuancheng01 wangyuancheng01 force-pushed the apig_auth branch 2 times, most recently from ecbc697 to c3616cb Compare May 21, 2024 04:40
@Lance52259
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@Lance52259
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 23, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve

@github-ci-robot github-ci-robot merged commit 56959bc into huaweicloud:master May 23, 2024
14 checks passed
@wangyuancheng01 wangyuancheng01 deleted the apig_auth branch May 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants