Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dds): support to set maintenance window for instance #4789

Merged
merged 1 commit into from May 14, 2024
Merged

feat(dds): support to set maintenance window for instance #4789

merged 1 commit into from May 14, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented May 11, 2024 •
edited

What this PR does / why we need it:
Support to set maintenance window for instance.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

 make testacc TEST="./huaweicloud/services/acceptance/dds" TESTARGS="-run TestAccDDSV3Instance_withConfigurationReplicaSet"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dds -v -run TestAccDDSV3Instance_withConfigurationReplicaSet -timeout 360m -parallel 4
=== RUN   TestAccDDSV3Instance_withConfigurationReplicaSet
=== PAUSE TestAccDDSV3Instance_withConfigurationReplicaSet
=== CONT  TestAccDDSV3Instance_withConfigurationReplicaSet
--- PASS: TestAccDDSV3Instance_withConfigurationReplicaSet (1820.21s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dds       1820.270s

@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_maintenance_window_for_instance branch from 47e5ed8 to bc3c9a3 Compare May 11, 2024 03:34
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 11, 2024
houpeng80
houpeng80 reviewed May 14, 2024
View reviewed changes
docs/resources/dds_instance.md Outdated
@@ -135,6 +137,10 @@ The following arguments are supported:

**NOTE:** The instance will be restarted in the background when switching SSL. Please operate with caution.

* `maintenance_window` - (Optional, String) Specifies the time range within which you are allowed to start a task that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to split it to two params, maintain_begin and maintai_end

@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_maintenance_window_for_instance branch from bc3c9a3 to e6a9db0 Compare May 14, 2024 03:28
@github-ci-robot github-ci-robot removed the LGTM /lgtm label May 14, 2024
@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_maintenance_window_for_instance branch from e6a9db0 to d158223 Compare May 14, 2024 09:38
@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2024
github-ci-robot
github-ci-robot approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit c6b7c29 into huaweicloud:master May 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houpeng80 houpeng80 houpeng80 left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot