refactor(apig/acl): support refresh functions for associate resource #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
Lance52259
changed the title
Lance52259
force-pushed
the
br_acl_associate_resource_upgrade
branch
from
98c56c5
to
4597f3a
Compare
deer-hang
reviewed
May 16, 2024
| @@ -61,6 +70,80 @@ func ResourceAclPolicyAssociate() *schema.Resource { | |||
| } | |||
| } | |||
|
|
|||
| func aclPolicyBindingRefreshFunc(client *golangsdk.ServiceClient, instanceId, policyId string, | |||
There was a problem hiding this comment.
What this method actually does is unbind.
There was a problem hiding this comment.
when we are binding APIs to a ACL policy, we will check whether include any API which is not bound again and again, and this operation is during the creation, so I names it as the aclPolicyBindingRefreshFunc.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support the refresh functions for the ACL policy associate resource.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed