Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdn): make ForceNew of name configurable #4632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jason-Zhang9309
Copy link
Collaborator

@Jason-Zhang9309 Jason-Zhang9309 commented Apr 17, 2024

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add common func FlexibleForceNew to make the ForceNew action configurable
2. use this func in cdn domain resource as an example

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/cdn' TESTARGS='-run TestAccCdnDomain_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccCdnDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccCdnDomain_basic
=== PAUSE TestAccCdnDomain_basic
=== CONT  TestAccCdnDomain_basic
--- PASS: TestAccCdnDomain_basic (704.94s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       704.991s

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Jason-Zhang9309

The full list of commands accepted by this bot can be found here.

@github-ci-robot
Copy link
Collaborator

You are the author and cannot comment /lgtm

@Jason-Zhang9309
Copy link
Collaborator Author

/hold

@github-ci-robot github-ci-robot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@deer-hang
Copy link
Contributor

Rename file name from forceNew.go to force_new.go

@deer-hang
Copy link
Contributor

Add test cases for changes in the config directory.

@github-ci-robot
Copy link
Collaborator

This PR needs rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase refactor size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants