Add bubble_env to benchmark.
#1814
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to match the changes to the competition environment inspired by #1838 (comment) and particularly #1846. |
Gamenot
force-pushed
the
tucker/add-driving_smarts_full_v0
branch
from
42334ff
to
05c7d27
Compare
Gamenot
force-pushed
the
tucker/add-driving_smarts_full_v0
branch
from
05c7d27
to
41eee14
Compare
Adaickalavan
reviewed
Mar 8, 2023
Comment on lines
+38
to
+45
| traffic_mode (Literal["traffic_A"]): The version of bubble traffic to use. | ||
| action_space (ActionSpaceType): The action space the agent should use. | ||
| img_meters (float): The square side dimensions of the surface the top-down rgb image | ||
| portrays. This affects resolution. | ||
| img_pixels (float): The total number of pixels in the top-down rgb image. This affects | ||
| resolution. | ||
| headless (bool): If the environment should display sumo-gui. | ||
| seed (int): The seed of the environment. |
There was a problem hiding this comment.
Docstring needs to be updated to match the checked_bubble_env_v0() input parameters.
Adaickalavan
reviewed
Mar 8, 2023
| from smarts.core.agent_interface import AgentInterface | ||
|
|
||
|
|
||
| def checked_bubble_env_v0( |
There was a problem hiding this comment.
Perhaps simply name it as bubble_env_v0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG.md.