Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require.main.require for hubot is not in packages.json #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mose
Copy link
Collaborator

@mose mose commented Sep 4, 2016

We could add hubot in devDependencies, but this require.main.require works when in production (stolen from hubot-slack plugin) and when hubot is not installed globally.

@huafu
Copy link
Owner

huafu commented Nov 22, 2017

Yeah AFAIR I did not want to add hubot as any level of dependency so that it could be using the version of the system.
IDK what's best, adding as a dev-dep or doing this require.main... Maybe we should create another file hubot.coffee which will be just resolving that dependency, trying to get it from require.main.require and else falling back to the devDependency one with normal require...

@davidchambers davidchambers changed the base branch from develop to master March 3, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants