Custom config and code refectoring #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small note was added about the "User" option within tor config file and a possible command for SELinux allow the user to manage DNS ports. This way we may avoid futures questions around the same thing.
This new feature allows the user to specify custom tor configurations that he may have created manually or from Nipe itself (through "install" command) using the '-c' flag with "start" command. $ ./nipe.pl start -c $HOME/.nipe_torrc In case the user's config doesn't contain some of the values required by Nipe, it will use its defined default value. For now the default values are hardcoded within Nipe's source code, but may change in the future for a more flexible approach. With this new feature it's also possible for the user to issue two nipe start calls with different configuration files, creating conflitant firewall rules. Because of that a locking file scheme was used to make sure nipe is called only once and the "stop" call also terminates only the tor instance actually created by Nipe. Therefore, the user may have a tor instance running in parallel with nipe's specific instance.
The use of both "strict" and "warnings" is a well known practice in Perl code for generating further warnings for common cases where future misbehaviors may happen. With this patch, every Perl file has both compiler flags enabled. Alongside the flags enablement, this patch also bring the necessary modifications to allow the program to run normally.
|
Ah, the first commit on README is the same commit as applied in the PR #85 . Since this patchset was based on top of that PR. |
This was referenced Jan 24, 2020
|
This PR may also solve issue #24 . |
htrgouvea
approved these changes
Jan 30, 2020
|
Bruno, thank you very much for this contribution!! You solved a lot of problems and predicted some things, it is very valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two major issues:
#36 : by enabling the
-cflag onnipe.pl start, which accepts custom config files from the user and also by maintaining a "lock file" to follow tor instance started by nipe.#86 : which help developers not make some known and frequent mistakes.
For each issue there is a single patch, with detailed information on how they were tackled.