Re-export lifted Test.Hspec expectations

[Jonplussed]

Addresses #22

[Jonplussed]

This is failing when Travis builds README.lhs. Does anybody understand the error? That isn't a file edited in this pull request.

[sol]

@Jonplussed Sorry for getting back late. This looks mostly good. There are some minor things I'd like to change, I'll add comments inline.

I think the build failure is due to Test.Hspec.Wai.Expectation missing from the other-modules field in the cabal file.

[sol]

Even though I tend to follow the convention to use singular for almost everything, I would still go for Test.Hspec.Wai.Expectations here, because we already have Test.Hspec.Expectations.

[Jonplussed]

Fixed in caba301

[Jonplussed]

Thanks for the notes; will edit and resubmit.

[Jonplussed]

The build is still failing on with the message The command "ghc --make -package hspec2 -Wall -Werror -pgmLmarkdown-unlit README.lhs" exited with 1. Watching the build, it seems the README.lhs is being run while not containing fully-runnable Haskell code.

Was this file perhaps added to the repo outside of a pull request, bypassing the build server?

[sol]

The compile error is in test/Test/Hspec/Wai/JSONSpec.hs:25:48:, due to the re-exports.

[sol]

(see a6a54ba)

[sol]

Now that we already have name clashes, I'm actually inclined to rename shouldRespondWith to shouldReturn. I assume that shouldRespondWith is the most commonly needed combinator when testing a web app, so I would love to have the short name for it :).

And if somebody really needs the current shouldReturn-semantics, that is a trivial variation of shouldBe, say:

action `shouldReturn` 23

can be expressed as

action >>= (`shouldBe` 23)

[sol]

Oh, and we can actually depend on hspec-expectations-lifted.

[sol]

Just pushed it to master. Thanks a lot!

[Jonplussed]

😄 👍