RetroAchievements: Add support for hashing homebrew #19096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We finally defined a method in RetroAchievements/rcheevos#244 .
|
Would it be worth using 64MB purely because it's the max buffer size already used by rcheevos for retail PSP hashing? |
|
@LucasKell Yes, probably a good call, Jamiras made the same observation. Though such large PBPs are unlikely to be found in homebrew anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finally defined a method in RetroAchievements/rcheevos#244 .
I made a change to the proposed method to cap the hashed file size to 16MB to avoid memory allocation issues. This should be by far enough considering that normal EBOOTs (that don't contain ISOs) just can't be too large if they want to fit into RAM.