Update unittests for compatibility with ARM Macs #19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted crashing, OS upgrade?)
|
Aha, it seems it has started to run as ARM on CI... And, maybe the unittest hasn't worked correctly on ARM. The sampler test is obviously broken (since we don't have a sampler jit for ARM but the test insists on it). |
|
The remaining failures are a minor different in the output of the VFPU instruction vh2f, (convert half to float, which the PSP's CPU does slightly different to the built-in instruction on ARM), and a slight difference in the software renderer in the test Correct:
Incorrect:
I'm gonna ignore that test for now, though it is a good one for checking the software renderer. |
… working 100% on ARM
hrydgard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why it started crashing, CI OS upgrade?