Suggestion improvements (2)

[LinqLover]

This PR proposes further improvements, new hooks, and some fixes to the suggestions infrastructure. Depends on (and includes) #108.

st/core: dispatch gathering of completion suggestions to containingArtefact for specialization (ab393e3)

For instance, sonyx overrides some of these new 'artefactCompletion' hooks in order to minimize the selector list, add custom selectors, or insert instances from a subclass of SBSuggestionItem.

Video (🔊):

sonyxSoundSuggestions.mp4

Open issues on this change:

• Test thoroughly. There might be use cases of the suggestions I am not aware of and thus might have broken. Especially, please check the experience for ordering and availability of suggestions depending on their length vs. typographic distance (fuzzy matching) vs. semantic distance (type guessing).
• Maybe we should even have real acceptance tests for this to make sure that all relevant use cases are covered?
• Discuss the right place for the dispatching hooks. Currently, the collection of completions and suggestions is delegated to the containingArtefact, making it possible for other projects (like sonyx) to subclass SBStContainer. However, this is not necessarily the single truth. Maybe alternatively/additionally dispatch the creation via the editor, the grammar handler, or a completely new entity?

st/core: provide hook Class>>#sandblocksMetaSuggestionsFor: (5f84560)

For instance, you could override the hook like this on Color to prioritize color names:

sandblocksMetaSuggestionsFor: aBlock
	
	^ self colorNames, (super sandblocksMetaSuggestionsFor: aBlock)

Sonyx makes use of this hook, too.

misc

• recategorizations (0d51099)

• st: reassure that return expressions can be print-itted (d0d80f9)

• core: fix SBSuggestionMenu>>#sandblockEditor (544932d)

  The menu is not a sub*morph of the editor, so we need to use the instvar here.

• core: fix dismissal of suggestions menu via click if #suggestAlways is true (ac89fb4)

  

[coveralls]

Pull Request Test Coverage Report for Build 1936438058

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 0.0%

---

Totals
Change from base Build 1922503786:	0.0%
Covered Lines:	0
Relevant Lines:	0

---

💛 - Coveralls