-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission SS22 #283
Open
matveysiva
wants to merge
23
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Submission SS22 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor: Replaced deprecated #startsWith * Fix: Adopted to Squeak 6.0 submenu changes
* Feat: Shortcut to clear search bar - Resolves #241 * Refactor: Used a better update mechanism * Refac: Refactored the test Co-authored-by: Frederic Sadrieh <frederic.sadrieh@student.hpi.de> Co-authored-by: Georg Auge <georg.auge01@gmail.com>
* Implemented keyword highlighting * Detect keywords that are not in lowercase * Fixed removeAttribute for CI * Fix testHighlightInterval for trunk version
* Fix: Remove algernon instances after tests are finished. - Resolves #245 Co-authored-by: Georg Auge <georg.auge01@gmail.com> * Fix: Algernon not activated after running tests Co-authored-by: Frederic Sadrieh <frederic.sadrieh@yahoo.com>
- expand ALGTestTypes>>testHasChildren - add ALGTestTypes>>testGitProjectTypeAppears - add ALGTestTypes>>testGitProjectOpenInGitBrowser - add ALGItemProvider class>>resetItems
- add class ALGGitProjectType - update ALGItemProvider - extend ALGIconFactory Resolves #249
- action 'open' is triggered by the already implemented keyword 'open' Resolves #256 Co-authored-by: Georg Auge <georg.auge01@gmail.com> Co-authored-by: Frederic Sadrieh <frederic.sadrieh@yahoo.com>
- update ALGGitProjectType>>algertemList to return empty list if SquitBrowser is not available - move related tests to class ALGTestGitProjectType and mark as expected failures if SquitBrowser is not available
…ting if SquitBrowser is not available - otherwise linting fails because classes fail on 'References an undeclared variable'
Git Access: Include git projects in Algernon search results with option to open in git browser
* Feat: implement equation solving - extend ALGExpressionType - show solved equation in Algernon directly - missing tests Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * Test: implement tests for Equation Solving -testing equation pattern -testing isEquation Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> Co-authored by: Yannik Dittmar <email@yannik-dittmar.de> * Fix: minor errors -catched division by zero -removed '^' from equation pattern Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * Fix: Test failed -fixed equation pattern test Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * FIx: equation pattern -modified equation pattern -added divide by zero test Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de>
* Test: install Squot before running tests - lets us test Git browser integration without requiring the user to install Squot - installs Squot during preTesting script - Resolves #268 Co-authored-by: Georg Auge <georg.auge01@gmail.com> * Test: add test to check if Squot is installed on the system Co-authored-by: Georg Auge <georg.auge01@gmail.com> * Fix: increase testing timeout - MacOS seems to need more than 15min to complete its test suite - not 100% sure if this works. * Refactor: use ```deny``` to avoid awkward ```not``` in test * Refactor: remove period to comply with coding style Co-authored-by: Frederic Sadrieh <frederic.sadrieh@yahoo.com>
To cover the git test, the CI, for the coverage needs to load in the Squit browser
* Refactor: Exchange method openGitBrowser for getGitBrowser in ALGGitProjectType * Feat: Add git commit action to Algernon * Refactor: Clean up implementation of #testGitProjectOpen * Test: Add tests for git actions push and pull * Feat: Add git actions push and pull to Algernon * Refactor: Recategorize #assertQuery:sendsMessageToSquitBrowser: * Refactor: Categorize class methods of ALGGitProjectType * Test: Declare global variable 'ALGSquitBrowser' before running ALGLinting Resolves #259, #270, #271
* Refactor: Clean up and extend ALGTestGitProjectType - rename test class to ALGTestGitTypes - refactor setUpTestWorkingCopy - recategorize git project test methods - match #expectedFailures to new categorization - add branches to mockWorkingCopy * Test: Add tests for ALGGitBranchType - test #getGitBrowser has proper branch selected - test action open - test appearance in default search and as children - test has-children * Feat: Add git branch type to Algernon - add subclasses ALGGitRemoteBranchType, ALGGitLocalBranchType - add actions open, switch - add git branches to git project type as children - add keyword 'switch' - extend ALGLinting class exceptions to git branch types - (current icons are temporary placeholders) Resolves #266 * Test: Add tests for git branch type switch-action - refactor ALGFakeActionTarget - add ALGFakeBranch - add tests * Fix: Declare global variable 'ALGRemoteBranch' before running ALGLinting * Test-Fix: Set up GitStamp before running tests for git types - set values for 'DefaultName' and 'DefaultEmail' - restore previous values during #tearDown Co-authored-by: Leonard Horns <leonard.horns@student.hpi.de>
* Refactor: start linting until "Shotgun surgery" (incl.) * WIP: First refactoring step * WIP: Some more refactoring Co-authored-by: Frederic Sadrieh <frederic.sadrieh@yahoo.com>
(test if SquitBrowser is installed)
* Update README.md * Update README.md
* Feat: Added Google Web Search preference options * WIP-Feat: Show web search results in Algernon * Feet: Implement web keyword. Resolves #242 Co-authored-by: Georg Auge georg.auge01@gmail.com * Feat-MVP: Search for something on the internet and display it inside of Algernon. * Refactor: Extended MVP fpr web search. - Added hidden actions - Added option to keep Algernon open on executing an action - Added custom max items per category for each type * Refactor/Fix: Web Search - Moved yieldTop and maxItemsPerCategory to class constants - Fixed ALGTypeCategorizer - Fixed keepOpen in doActionOnSelectedItem - Increased timeout for linting - Added displayLink and link variable for WebResultType * Feat: Added status text for web search * Feat: Open search result in default browser. - Tested for Linux (Kali) and Windows. Might require more testing for Mac OS and other Linux distros. * Fix: Unix browser commands * Fix: Linter issues in ALGWebResultType Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * Fix: Added needed packages to baseline Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * Fix: testTabExecutesSingleActionResultNested - Somhow the CI has other items than the BaselineOfAlgernon category at the top result. The test fails, because it depends on child items of the category item. Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> * Fix: Added first Web Search test. * Fix: Add tests for web search Co-authored-by: Leonard Horns <leonard.horns@student.hpi.de> * Fix: Add ALGOSProcess as global variable for linter, Add comment * Test: Add test for ALGWebSearchType>>displayError & rm unused method (remove accessor ALGWebResultType>>resultDisplayLink since it is unused) * Refactored: Till shot gun surgery * Refactor: Completed SWA linter, applied style guide * Refactor: More style guide * Fix: Increased Baseline test timeout for macOS * Refactor: Added class comments * Refactor: Applied style guide: createCategoriesFor Co-authored-by: Frederic Sadrieh <frederic.sadrieh@yahoo.com> Co-authored-by: Elias Fiedler <elias.fiedler@gmx.de> Co-authored-by: Leonard Horns <leonard.horns@student.hpi.de> Co-authored-by: Leonard Horns <leonardhorns@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a summary of all the new features, check out our latest release releases 5.0.0.
~Algernon SWT Group 2022