Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5611 - add new create-task-endpoint #3339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wolfganggreschus
Copy link

@wolfganggreschus wolfganggreschus commented Oct 25, 2023

Description

This pr is part of the migration of homework from Feathers to NestJS. There is an existing Task module in Nest where the logic for creating a new task (homework) should be implemented. The old create-homework procedure should be removed.
The frontend should utilize the new endpoint. Ensure that there are no requests using the old endpoint

Links to Tickets or other pull requests

BC-5611
hpi-schul-cloud/schulcloud-server#4499

Changes

Remove request utilizing "POST /homework/{id}"
Use "POST /api/v3/task/{id}"

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants